Daniel Erez has posted comments on this change.
Change subject: engine: Ties more consitently between vm disk device and disk
entities.
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 738: } else {
Line 739:
getTaskIdList().addAll(result.getInternalVdsmTaskIdList());
Line 740: DiskImage newImage = (DiskImage)
result.getActionReturnValue();
Line 741: srcDiskToTargetDiskMapping.put(dit.getId(),
newImage.getId());
Line 742: newDiskImages.add(newImage);
instead of keeping a map and a list, can we combine them to a single map? E.g.
'id' to 'disk' (to avoid maintaining two data structures).
Line 743: }
Line 744: }
Line 745: }
Line 746: return true;
--
To view, visit http://gerrit.ovirt.org/17854
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bf284ea4e05f03fc0a7e94a1ec901aacbdc1ab1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Haim Ateya <hat...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
