Maor Lipchuk has posted comments on this change.
Change subject: engine: Ties more consitently between vm disk device and disk
entities.
......................................................................
Patch Set 2:
(2 comments)
how can we be sure that there are no VMs which were exported without an address
in their vmDevice.
What will happened if we will import those vms/templates later, will we
encounter the same issue?
....................................................
Commit Message
Line 3: AuthorDate: 2013-08-08 22:54:26 +0300
Line 4: Commit: Sergey Gotliv <sgot...@redhat.com>
Line 5: CommitDate: 2013-08-09 01:39:39 +0300
Line 6:
Line 7: engine: Ties more consitently between vm disk device and disk entities.
/s/consitently/consistently
Line 8:
Line 9: VmDevice is the model entity on the Engine that ties between VM and
Line 10: the disk attached to this VM. Disk is not the only entity which tied to
Line 11: VM by VmDevice, but the only to be affected by this patch.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
Line 169: * @param result
Line 170: * result of execution of child command
Line 171: */
Line 172: private void handleCopyResult(DiskImage srcDiskImage, DiskImage
copiedDiskImage,
Line 173: VdcActionParametersBase parameters,
VdcReturnValueBase result) {
Not related to this fix, but why do we need to pass here the parameters?
Line 174: // If a copy cannot be made, abort
Line 175: if (!result.getSucceeded()) {
Line 176: throw new
VdcBLLException(VdcBllErrors.VolumeCreationError);
Line 177: } else {
--
To view, visit http://gerrit.ovirt.org/17854
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8bf284ea4e05f03fc0a7e94a1ec901aacbdc1ab1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Haim Ateya <hat...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
