Moti Asayag has posted comments on this change. Change subject: engine: Drop PORT_MIRRORING action group ......................................................................
Patch Set 10: > what about old roles user have created to manage "port mirroring"? do you > address them when upgrading to 3.3 by creating relevant profiles with > permissions? The port mirroring action group is deleted during upgrade time from an existing roles. If there was a usage of port mirroring for a network, a profile with port mirroring will be created to it and will be granted for the user. Therefore existing functionality should remain as before. anyway this is behaviour change that not appropriate for the minor version, this is a subject for the api-v2 (which may be available in the 3.4) also if port mirroring was removed from the previous resources we should revert this change. port mirroring wasn't removed from the rest Nic resource (or vm/template), nor from its api (vm/template add/update). the logic for backward compatibility resides on engine commands, so user's old script can continue working properly with providing network name and port mirroring as long as the user have permission on vnic profile set for port mirroring for the target network. -- To view, visit http://gerrit.ovirt.org/17741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3111db10372deaa4a244b4d253b72326edd56fe8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
