Moti Asayag has posted comments on this change. Change subject: engine: Drop PORT_MIRRORING action group ......................................................................
Patch Set 10: > Michael Pasternak Aug 10 11:37 PM > Patch Set 9: > not sure i follow, what about backward compatibility? iirc p/m was introduced > in 3.2 ... The port mirroring was introduced in 3.1. The port mirroring feature will remain in 3.3, but managing its permission or its level of configuration was changed: the engine allow to define if a vnic is set for port mirroring by the profile definition which the vnic uses. If the user uses the old api for providing network name + port mirroring when adding a vnic or updating an existing one, the engine will look up for an appropriate profile. The action group of port mirroring isn't relevant since the VnicProfileUser role which is granted on the vnic profile determines which users can use the profile (whether it is port mirroring or not). -- To view, visit http://gerrit.ovirt.org/17741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3111db10372deaa4a244b4d253b72326edd56fe8 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
