Alon Bar-Lev has posted comments on this change.
Change subject: host-deploy: lock vds when installing
......................................................................
Patch Set 2: Verified+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
Line 28: import org.ovirt.engine.core.utils.log.Log;
Line 29: import org.ovirt.engine.core.utils.log.LogFactory;
Line 30: import org.ovirt.engine.core.vdsbroker.vdsbroker.VDSNetworkException;
Line 31:
Line 32: @LockIdNameAttribute
this was the missing bit, although it looks trivial for you guys... it is
unexpected in proper design. if you have a base class then I expect the
getExclusiveLocks() to be called and base class to return none.
annotations should mark external behaviors.
Line 33: @NonTransactiveCommandAttribute
Line 34: public class InstallVdsCommand<T extends InstallVdsParameters> extends
VdsCommand<T> {
Line 35:
Line 36: private static Log log =
LogFactory.getLog(InstallVdsCommand.class);
--
To view, visit http://gerrit.ovirt.org/17892
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bbd1102e85d30176c123ebb1999522a667c4e47
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
