Allon Mureinik has posted comments on this change. Change subject: host-deploy: lock vds when installing ......................................................................
Patch Set 1: > Oh... I thought that executeCommand() is invoked when > command is invoked and lock will be held as long as command > runs, and free when it finish. Yes, this is correct. However, if the executeCommand() does not finish the job (e.g., submits a VDSM task, and then has something else poll the status), you'll have to do something a bit fancier (e.g., have the status in the DB). Hence my question - if executeCommand() blocks 'till the installation is done, you're fine. > Can you please refer me to an example in which there is a > lock on vds so that no other command may be executed at > that time? As I said, your solution looks OK, but feel free to refer to org.ovirt.engine.core.bll.RemoveVdsCommand#getExclusiveLocks if you want another example. -- To view, visit http://gerrit.ovirt.org/17892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bbd1102e85d30176c123ebb1999522a667c4e47 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
