Yair Zaslavsky has posted comments on this change.
Change subject: core: Fix compareTo for SRV records
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/tools/src/test/java/org/ovirt/engine/core/utils/dns/DnsSRVLocatorTest.java
Line 41: }
Line 42:
Line 43: @Test
Line 44: public void testZeroPriorities() throws Exception {
Line 45: DnsSRVLocator locator = mockLocator("example.com",
Indeed.
It would be nice if I could let's say invoke with the new SrvRecord.compareTo,
and without it...
So in my patches,i the previous patch the test class is introduced when
compareTo's new behavior is not introduced. if you run the test - it will fail.
Here the test succeeds.
Line 46: "10 100 389 a.example.com.",
Line 47: "10 100 389 b.example.com.",
Line 48: "10 100 389 c.example.com.",
Line 49: "10 100 389 d.example.com.",
--
To view, visit http://gerrit.ovirt.org/17049
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff93a85f529633934515015653c517500bf51c6b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
