Hello Alex Lourie,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/17900

to review the following change.

Change subject: packaging: db: Updated psql usage never to ask passwords
......................................................................

packaging: db: Updated psql usage never to ask passwords

Change-Id: Id44f803bafdcc0c5bc059b59842cff54e2e8e584
Signed-off-by: Alex Lourie <alou...@redhat.com>
---
M packaging/dbscripts/create_schema.sh
M packaging/dbscripts/dbfunctions.sh
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/00/17900/1

diff --git a/packaging/dbscripts/create_schema.sh 
b/packaging/dbscripts/create_schema.sh
index 567167a..06ed77a 100755
--- a/packaging/dbscripts/create_schema.sh
+++ b/packaging/dbscripts/create_schema.sh
@@ -45,7 +45,7 @@
     esac
 done
 
-createlang --host=${SERVERNAME} --port=${PORT} --dbname=${DATABASE} --echo 
--username=${USERNAME} plpgsql >& /dev/null
+createlang -w --host=${SERVERNAME} --port=${PORT} --dbname=${DATABASE} --echo 
--username=${USERNAME} plpgsql >& /dev/null
 #set database min error level
 CMD="ALTER DATABASE \"${DATABASE}\" SET client_min_messages=ERROR;"
 execute_command "${CMD}"  ${DATABASE} ${SERVERNAME} ${PORT}> /dev/null
diff --git a/packaging/dbscripts/dbfunctions.sh 
b/packaging/dbscripts/dbfunctions.sh
index f50bac5..26e844a 100755
--- a/packaging/dbscripts/dbfunctions.sh
+++ b/packaging/dbscripts/dbfunctions.sh
@@ -115,7 +115,7 @@
     #
     CMD="select count(*) from pg_proc where proname = 'uuid_nil';"
     if [ "$(execute_command "$CMD" ${DATABASE} ${SERVERNAME} ${PORT} | sed -e 
's/ //g' -e '/^$/d')" != 0 ]; then
-        psql -U postgres -h ${SERVERNAME} -p ${PORT} -f 
drop_old_uuid_functions.sql ${DATABASE} > /dev/null
+        psql -w -U postgres -h ${SERVERNAME} -p ${PORT} -f 
drop_old_uuid_functions.sql ${DATABASE} > /dev/null
     fi
     # recreate generic functions
     execute_file "create_functions.sql" ${DATABASE} ${SERVERNAME} ${PORT} > 
/dev/null


-- 
To view, visit http://gerrit.ovirt.org/17900
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id44f803bafdcc0c5bc059b59842cff54e2e8e584
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to