Greg Sheremeta has uploaded a new change for review. Change subject: webadmin: fixed edit name availability in tree context ......................................................................
webadmin: fixed edit name availability in tree context When a specific item (for example, an actual host -- not "Hosts") is selected in the left-pane tree, we need to disable editing the name of that item. Change-Id: Ie50a6fcfeacdc94fe900f6569180106c31f5e9c8 Bug-Url: https://bugzilla.redhat.com/858952 Signed-off-by: Greg Sheremeta <gsher...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java 2 files changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/86/17886/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java index 5b8f68c..b3aa4a0 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java @@ -425,7 +425,8 @@ } })); - if (getSystemTreeSelectedItem() != null && getSystemTreeSelectedItem().getType() == SystemTreeItemType.Cluster) { + if (getSystemTreeSelectedItem() != null && (getSystemTreeSelectedItem().getType() == SystemTreeItemType.Cluster || + getSystemTreeSelectedItem().getType() == SystemTreeItemType.Cluster_Gluster)) { clusterModel.getName().setIsChangable(false); clusterModel.getName().setInfo("Cannot edit Cluster's Name in tree context"); //$NON-NLS-1$ } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java index de76c24..03b2fa9 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java @@ -745,9 +745,17 @@ command.setTitle(ConstantsManager.getInstance().getConstants().cancel()); command.setIsCancel(true); hostModel.getCommands().add(command); + + if (getSystemTreeSelectedItem() != null && getSystemTreeSelectedItem().getType() == SystemTreeItemType.Host) { + hostModel.getName().setIsChangable(false); + hostModel.getName().setInfo("Cannot edit Host's Name in tree context"); //$NON-NLS-1$ + } + } }; AsyncDataProvider.getDataCenterList(_asyncQuery); + + } public void onSaveFalse() -- To view, visit http://gerrit.ovirt.org/17886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie50a6fcfeacdc94fe900f6569180106c31f5e9c8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
