Yair Zaslavsky has posted comments on this change. Change subject: Fix log print values when vdsm version is not supported in cluster ......................................................................
Patch Set 3: (3 comments) .................................................... Commit Message Line 5: CommitDate: 2013-08-07 16:55:33 +0300 Line 6: Line 7: Fix log print values when vdsm version is not supported in cluster Line 8: Line 9: Before we print the same log as we print when cluster supported version Commit message is too obscure Please elaborate more thanks Line 10: is not compatible with VDS version. Line 11: Line 12: Change-Id: Iacfb3875a0617f978b4453769a0b1c5704282fa5 Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=974101 .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java Line 54: Line 55: // move to non operational if vds-vdc version not supported OR cluster Line 56: // version is not supported Line 57: if (!Config.<HashSet<Version>> GetValue(ConfigValues.SupportedVDSMVersions).contains(vdsmVersion)) { Line 58: ReportNonOperationReason(NonOperationalReason.VERSION_INCOMPATIBLE_WITH_CLUSTER, please make sure the method name begins with a lower case. Line 59: Config.<HashSet<Version>> GetValue(ConfigValues.SupportedVDSMVersions).toString(), Line 60: vdsmVersion.toString()); Line 61: } Line 62: else if (!VersionSupport.checkClusterVersionSupported(cluster.getcompatibility_version(), vds)) { .................................................... File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties Line 347: USER_CLEAR_UNKNOWN_VMS=All VMs' status on Non Responsive Host ${VdsName} were changed to 'Down' by ${UserName} Line 348: USER_FAILED_CLEAR_UNKNOWN_VMS=Failed to clear VMs' status on Non Responsive Host ${VdsName}. (User: ${UserName}). Line 349: CERTIFICATE_FILE_NOT_FOUND=Could not find oVirt Engine Certificate file. Line 350: VDS_RUN_IN_NO_KVM_MODE=Host ${VdsName} running without virtualization hardware acceleration Line 351: VDS_VERSION_NOT_SUPPORTED_FOR_CLUSTER=Host ${VdsName} is installed with VDS version (${VdsSupportedVersions}) and cannot join cluster ${VdsGroupName} which is compatible with VDS versions ${CompatibilityVersion}. Use VDSM or host instead of "VDS" at "VDS version". Line 352: VDS_CLUSTER_VERSION_NOT_SUPPORTED=Host ${VdsName} is compatible with versions (${VdsSupportedVersions}) and cannot join Cluster ${VdsGroupName} which is set to version ${CompatibilityVersion}. Line 353: RUN_VM_FAILED=Cannot run VM ${VmName} on Host ${VdsName}. Error: ${ErrMsg} Line 354: USER_ADD_PERMISSION=User/Group ${SubjectName} was granted permission for Role ${RoleName} on ${VdcObjectType} ${VdcObjectName}, by ${UserName}. Line 355: USER_ADD_PERMISSION_FAILED=User ${UserName} failed to grant permission for Role ${RoleName} on ${VdcObjectType} ${VdcObjectName} to User/Group ${SubjectName}. -- To view, visit http://gerrit.ovirt.org/17719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacfb3875a0617f978b4453769a0b1c5704282fa5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
