Maor Lipchuk has posted comments on this change. Change subject: Fix log print values when vdsm version is not supported in cluster ......................................................................
Patch Set 1: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java Line 79: } Line 80: if (!VersionSupport.checkClusterVersionSupported(cluster.getcompatibility_version(), vds)) { Line 81: Map<String, String> customLogValues = new HashMap<String, String>(); Line 82: customLogValues.put("CompatibilityVersion", cluster.getcompatibility_version().toString()); Line 83: customLogValues.put("VdsSupportedVersions", vds.getSupportedClusterLevels()); Isn't it should be now VdsSupportedClusters Line 84: SetNonOperationalVdsParameters tempVar = new SetNonOperationalVdsParameters(getVdsId(), Line 85: CLUSTER_VERSION_INCOMPATIBLE_WITH_CLUSTER, Line 86: customLogValues); Line 87: tempVar.setSaveToDb(true); -- To view, visit http://gerrit.ovirt.org/17719 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacfb3875a0617f978b4453769a0b1c5704282fa5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches