Juan Hernandez has posted comments on this change. Change subject: core: Introduce CDI for Commands dependencies ......................................................................
Patch Set 8: (1 comment) .................................................... File backend/manager/modules/bll/pom.xml Line 140: <dependency> Line 141: <groupId>javax.enterprise</groupId> Line 142: <artifactId>cdi-api</artifactId> Line 143: <scope>provided</scope> Line 144: </dependency> It isn't good to rely on transitive dependencies. What if in the future the cdi-api artifact doesn't depend on the javax.inject artifact? The build will fail. I acknowledge that the probability of this is very low, but any how it is good practice to be explicit and include in the list of the dependencies anything that you are importing in the source. I mean, if you have "import whatever;" in the Java source then you should explicitly have a dependency for that in the POM. Line 145: </dependencies> Line 146: Line 147: <build> Line 148: -- To view, visit http://gerrit.ovirt.org/5575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7f604ff91847b698efe84a09f724ba0492a672c1 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Asaf Shakarchi <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
