Liran Zelkha has posted comments on this change.
Change subject: core: Introduce CDI for Commands dependencies
......................................................................
Patch Set 8:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 131: protected Log log = LogFactory.getLog(getClass());
Line 132:
Line 133: @Inject
Line 134: protected DbFacade dbFacade;
Line 135:
The idea here is to have CDI inject the right mocks in tests, so we don't have
to do it. I think just adding setters/getters will expose private members to
the outside world.
Line 136: /** The context defines how to monitor the command and handle its
compensation */
Line 137: private final CommandContext context = new CommandContext();
Line 138:
Line 139: /** A map contains the properties for describing the job */
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Injector.java
Line 4: import javax.enterprise.inject.spi.BeanManager;
Line 5: import javax.naming.InitialContext;
Line 6: import javax.naming.NamingException;
Line 7:
Line 8: public class Injector {
I don't like this class. We should find a better way to do this. Some ideas -
aspects, our own class loader. This is bad, as it is very error prone (can a
class be sometimes created with the Injector and sometimes without...)
Line 9:
Line 10: private BeanManager manager;
Line 11:
Line 12: public Injector() {
Line 10: private BeanManager manager;
Line 11:
Line 12: public Injector() {
Line 13: try {
Line 14: this.manager = (BeanManager) new
InitialContext().lookup("java:comp/BeanManager");
+1
Line 15: } catch (NamingException e) {
Line 16: // if the bean manager couldn't be fetched then we
couldn't inject dependencies to non-bean objects
Line 17: throw new RuntimeException("Couldn't locate a BeanManager
instance due to " + e.getMessage()
Line 18: + " Actions will fail to perform due to runtime
missing dependencies");
--
To view, visit http://gerrit.ovirt.org/5575
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f604ff91847b698efe84a09f724ba0492a672c1
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
