Alon Bar-Lev has posted comments on this change.
Change subject: oVirt Node Upgrade: Support N configuration
......................................................................
Patch Set 16:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
Line 44:
Line 45: RpmVersion vdsOsVersion =
VdsHandler.getOvirtHostOsVersion(vds);
Line 46: String nodeOS = vds.getHostOs();
Line 47: String nodeOsSupported = null;
Line 48: Matcher matcher;
where is it used?
Line 49:
Line 50: for (OVirtNodeInfo.Entry info :
OVirtNodeInfo.getInstance().get()) {
Line 51:
Line 52: try {
Line 55: matcher =
info.nodePattern.matcher(nodeOS.toLowerCase());
Line 56: matcher.find();
Line 57: nodeOsSupported = matcher.group(0);
Line 58: log.infoFormat("nodeOS [{0}] supported node OS [{1}]",
nodeOS.toLowerCase(), nodeOsSupported);
Line 59: } catch (RuntimeException e) {
what triggers RuntimeExcpetion?
Line 60: log.infoFormat("Cannot match nodeOS [{0}]]",
nodeOS.toLowerCase());
Line 61: continue;
Line 62: }
Line 63:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1461: @DefaultValueAttribute("3")
Line 1462: IterationsWithBalloonProblem(525),
Line 1463:
Line 1464: @TypeConverterAttribute(String.class)
Line 1465: @DefaultValueAttribute("^ovirt.*:^rhev.*")
still two entries.... while default configuration is not set for two.
Line 1466: oVirtNode(525),
Line 1467:
Line 1468: Invalid(65535);
Line 1469:
--
To view, visit http://gerrit.ovirt.org/14756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Michael Burns <mbu...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
