Alon Bar-Lev has posted comments on this change.
Change subject: oVirt Node Upgrade: Support N configuration
......................................................................
Patch Set 18:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetoVirtISOsQuery.java
Line 49: try {
Line 50: log.infoFormat("nodeOS [{0}]", nodeOS.toLowerCase());
Line 51: log.infoFormat("info.osPattern [{0}]", info.osPattern);
Line 52: matcher = info.osPattern.matcher(nodeOS.toLowerCase());
Line 53: if (!matcher.find()) {
?
if (!info.osPattern.matcher(nodeOS.toLowerCase()).find()) {
continue;
}
Line 54: continue;
Line 55: }
Line 56: } catch (RuntimeException e) {
Line 57: log.infoFormat("Cannot match nodeOS [{0}]]",
nodeOS.toLowerCase());
Line 56: } catch (RuntimeException e) {
Line 57: log.infoFormat("Cannot match nodeOS [{0}]]",
nodeOS.toLowerCase());
Line 58: }
Line 59:
Line 60: if (info.path.isDirectory()) {
and what if not found at all?
Line 61: log.debugFormat("Looking for list of ISOs in [{0}]",
info.path);
Line 62: log.debugFormat("regex isoPattern for ISOs: [{0}]",
info.isoPattern);
Line 63: for (File file : info.path.listFiles()) {
Line 64: matcher = info.isoPattern.matcher(file.getName());
--
To view, visit http://gerrit.ovirt.org/14756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfb9dc5d0dc8780b519107acbe0ae866831f782c
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Michael Burns <mbu...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
