Alon Bar-Lev has posted comments on this change.
Change subject: engine_page: rewrite register
......................................................................
Patch Set 4:
(2 comments)
....................................................
File src/misc.py
Line 206: def get_ovirtnode_kernel_params(self):
Line 207:
Line 208: kparams = {}
Line 209: try:
Line 210: with open(self._OVIRTNODE_KERNEL_OPTS, 'r') as configfile:
why not use configparser?
Line 211: for line in configfile:
Line 212: if "OVIRT_BOOTPARAMS" in line:
Line 213: for item in line.split("\"")[1].split(" "):
Line 214: if "=" in item:
Line 218: kparams.update({item:''})
Line 219: except Exception as e:
Line 220: logging.debug(
Line 221: "Cannot get kernel params %s error %s",
Line 222: self._OVIRTNODE_KERNEL_OPTS, e)
please use our otopi conventions...
self.logger.debug(
"bla bla",
prm,
prm,
)
Line 223:
--
To view, visit http://gerrit.ovirt.org/17682
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38f3b800c445f8dbb0fa0e89d128cea1e3407798
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-node-plugin-vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
