Alon Bar-Lev has posted comments on this change. Change subject: engine_page: rewrite register ......................................................................
Patch Set 3: (4 comments) .................................................... File src/engine_page.py Line 340: # pylint: enable-msg=E0611,F0401 Line 341: Line 342: cfg = VDSM().retrieve() Line 343: Line 344: if not self._newreg: even at old vdsm-reg we should have valid vdsmid, so please call it to create one. The code should be shared between these two modes. Same python module/class that receives these parameters: 1. engine URL 2. >=3.2 to support legacy kernel parameters, take the host and port and transform to URI using https://host:port and !>=3.2. new kernel parameters of url + new server should be added. Line 345: self.logger.info("VDSM-reg registering..") Line 346: # Stopping vdsm-reg may fail but its ok - its in the case when the Line 347: # menus are run after installation Line 348: self.logger.info("Stopping vdsm-reg service") .................................................... File src/misc.py Line 184: ) Line 185: if rc != 0 or len(stdout) != 1: Line 186: self.logger.warning('Invalid dmidecode output') Line 187: elif stdout[0].startswith('Not '): Line 188: self.logger.warning('No system uuid') you do not need a warning, this is valid, you can debug. Line 189: else: Line 190: vdsmId = stdout[0] Line 191: elif arch in ('ppc', 'ppc64'): Line 192: #eg. output IBM,03061C14A Line 197: if vdsmId is None: Line 198: vdsmId = str(uuid.uuid4()) Line 199: with open(self._P_VDSM_NODE_ID, 'w') as f: Line 200: f.write(vdsmId) Line 201: utils.fs.Config().persist(self._P_VDSM_NODE_ID) this should go out of the with Line 202: .................................................... File src/network.py Line 1: #!/usr/bin/python please remove this file we do not need it. Line 2: # -*- coding: utf-8 -*- Line 3: # Line 4: # network.py - Copyright (C) 2013 Red Hat, Inc. Line 5: # -- To view, visit http://gerrit.ovirt.org/17682 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38f3b800c445f8dbb0fa0e89d128cea1e3407798 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
