Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: Add host rename script
......................................................................
Patch Set 21:
(2 comments)
....................................................
File packaging/setup/plugins/ovirt-engine-rename/core/database.py
Line 126: select
Line 127: connection
Line 128: from storage_server_connections
Line 129: where
Line 130: id=%(storage)s
Please do not take anything from legacy... this is going to be removed in next
release... so I do not care much of it.
Please use join.
Line 131: """,
Line 132: args=dict(
Line 133: storage=domain['storage']
Line 134: ),
Line 176: statement.updateVdcOptions(
Line 177: options=(
Line 178: {
Line 179: 'name': option,
Line 180: 'value': newvalue,
I hate one time use of variables.... if you have object of urlparse... just use
it.
significant - no... just consistent with myself :)
Line 181: },
Line 182: )
Line 183: )
Line 184:
--
To view, visit http://gerrit.ovirt.org/17408
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
