Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Add host rename script ......................................................................
Patch Set 21: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-common/core/protocols.py Line 71: ) Line 72: self.environment.setdefault( Line 73: osetupcons.ConfigEnv.JBOSS_DIRECT_HTTPS_PORT, Line 74: None Line 75: ) What configuration? During a first setup there is no configuration. This is the only place where we set the defaults - all these constants are not used anywhere else. Perhaps I am missing something... Line 76: Line 77: @plugin.event( Line 78: stage=plugin.Stages.STAGE_SETUP, Line 79: ) -- To view, visit http://gerrit.ovirt.org/17408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28cb0285424236fd3e6907694f6bf1ce6ce3367f Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
