Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Add backup and restore utility
......................................................................
Patch Set 19: (4 inline comments)
....................................................
File packaging/bin/engine-backup.sh
Line 23: BACKUP_FOLDERS="/etc/ovirt-engine
Line 24: /etc/pki/ovirt-engine
Line 25: /etc/ovirt-engine-setup.conf.d
Line 26: /var/lib/ovirt-engine"
Line 27: VERSION_FILE="/usr/share/ovirt-engine/conf/version"
what about this one? Please add the required variables into the
engine-prolog.sh so we can remove this file.
Line 28: MYPGPASS=""
Line 29: TEMP_FOLDER=""
Line 30: FILE=""
Line 31: DB_BACKUP_FILE_NAME="engine_backup.db"
Line 79: --file=*)
Line 80: FILE="${v}"
Line 81: ;;
Line 82: --backup=*)
Line 83: BACKUP_FILE="${v}"
why --file cannot be used for both backup and restore?
Line 84: ;;
Line 85: --log=*)
Line 86: LOG="${v}"
Line 87: ;;
Line 136: createmd5() {
Line 137: local tardir="$1"
Line 138: local md5file="$2"
Line 139: find "${tardir}" -type f -printf "%P\n" | while read file; do
Line 140: ( cd "${tardir}" && md5sum "${file}" >> "${md5file}" )
|| die "Cannot create checksum for '${file}'"
great! one minor fixup...
(cd "${tardir}" && md5sum "${file}") >> "${tardir}/${md5file}" || die ...
Notice that the subshell is only for the command, the md5file is not effected.
Line 141: done || die "Find execution failed"
Line 142: }
Line 143:
Line 144: verifymd5() {
Line 248: __EOF__
Line 249: }
Line 250:
Line 251: output() {
Line 252: echo "$1"
write to the log as well?
die should also write to the log.
also progress and checkpoints should be written to log, to help you perform
remote support., this is sensitive process.
Line 253: }
Line 254:
Line 255: ## Main
Line 256:
--
To view, visit http://gerrit.ovirt.org/15276
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6c386a0f48ccd520978193639120999e00cf2a
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
