Ofer Schreiber has posted comments on this change.

Change subject: packaging: Add backup and restore utility
......................................................................


Patch Set 13: I would prefer that you didn't submit this

(1 inline comment)

WIP
Basic restore flow works.

....................................................
File packaging/bin/engine-backup.sh
Line 160: restoreDB() {
Line 161:       # TODO: Supress psql output
Line 162:       # TODO: Verify DB exists and empty
Line 163:       local backupfile="$1"
Line 164:       PGPASSFILE="${MYPGPASS}" psql \
reverted to psql.
using the pg_restore with format=c in pg_dump requires more permissions than we 
have with the engine user we user during restore
Line 165:               -w \
Line 166:               -U "${ENGINE_DB_USER}" \
Line 167:               -h "${ENGINE_DB_HOST}" \
Line 168:               -p "${ENGINE_DB_PORT}" \


-- 
To view, visit http://gerrit.ovirt.org/15276
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7f6c386a0f48ccd520978193639120999e00cf2a
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to