Yair Zaslavsky has posted comments on this change.
Change subject: engine : Null Pointer Exception for action
CreateAllSnapshotsFromVm after failure in create snapshot
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 223: @Override
Line 224: protected void endVmCommand() {
Line 225: // The following code must be executed in an inner
transaction to make the changes visible
Line 226: // to the RunVm command that might occur afterwards
Line 227: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Allon, another question here - upon engine restart , as Ravi described in the
commit msg, if the snapshot entry was compensated, don't we want to end with
failure somehow?
Line 228:
Line 229: @Override
Line 230: public Void runInTransaction() {
Line 231: final boolean taskGroupSucceeded =
getParameters().getTaskGroupSuccess();
--
To view, visit http://gerrit.ovirt.org/17590
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If89c45a236029078eae4a4254837b373c88adfd2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
