Juan Hernandez has posted comments on this change.
Change subject: core: Cache JNDI lookups and InitialContext creation
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
A minor suggestion inside.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EJBUtilsStrategy.java
Line 48: }
Line 49:
Line 50: private static InitialContext context;
Line 51:
Line 52: private static synchronized InitialContext getInitialContext()
throws NamingException {
As this method is only called from inside getReference() and getReference() is
already synchronized you may want to avoid making this method itself
synchronized, it will be a bit faster that way. You may also want to put these
few lines of code inside getReference() and remove this method.
Line 53:
Line 54: if (context == null) {
Line 55: context = new InitialContext();
Line 56: }
--
To view, visit http://gerrit.ovirt.org/16612
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ae8d0a90a03c498e19e5429d196924671c073b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
