Allon Mureinik has posted comments on this change.
Change subject: core: Cache JNDI lookups and InitialContext creation
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ejb/EJBUtilsStrategy.java
Line 27: // Map from bean types (for example BeanTypeEnum.BACKEND) to their
JNDI
Line 28: // names
Line 29: protected HashMap<BeanType, String> beanTypeToJNDINameMap = new
HashMap<BeanType, String>();
Line 30:
Line 31: static private Map<String, Object> cachedJNDIReferences = new
HashMap<>();
should probably be private static final
Line 32:
Line 33: protected EJBUtilsStrategy() {
Line 34: // Adds JNDI resources,
Line 35: addJNDIResources();
--
To view, visit http://gerrit.ovirt.org/16612
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ae8d0a90a03c498e19e5429d196924671c073b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
