Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: host rename ......................................................................
Patch Set 4: (1 inline comment) just a note about database plugin, the rest of the code looks good to me .................................................... File packaging/setup/plugins/ovirt-engine-rename/core/database.py Line 1: #update database vdc_options Line 2: #dwh and report URLs?!?! If you're planning to add this plugin in this patch please add WIP in first line commit message. If it will not be included in this patch, this file can be removed. -- To view, visit http://gerrit.ovirt.org/17098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I100a602a199bac576bd9fad9e180f0ddbfa0ea5b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
