Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: host rename ......................................................................
Patch Set 1: (2 inline comments) Not sure I understand the difference between this and what I left... .................................................... File packaging/setup/plugins/ovirt-engine-rename/core/hostname.py Line 34: osetupcons.Stages.CONFIG_PROTOCOLS_CUSTOMIZATION, Line 35: ], Line 36: ) Line 37: def _customization(self): Line 38: # This forces hostname.py from ovirt-engine-setup to run why don't you use this as the new name? Line 39: self.environment[osetupcons.ConfigEnv.FQDN] = None Line 40: Line 41: .................................................... File packaging/setup/plugins/ovirt-engine-rename/core/__init__.py Line 30: @util.export Line 31: def createPlugins(context): Line 32: misc.Plugin(context=context) Line 33: hostname.Plugin(context=context) Line 34: #pki.Plugin(context=context) so where pki changes are performed? Line 35: Line 36: -- To view, visit http://gerrit.ovirt.org/17098 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I100a602a199bac576bd9fad9e180f0ddbfa0ea5b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
