Arik Hadas has posted comments on this change.
Change subject: core: ignore image does not exists error on remove memory state
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java
Line 88: }
Line 89: }
Line 90: catch(VdcBLLException e) {
Line 91: if (e.getErrorCode() ==
VdcBllErrors.ImageDoesNotExistInDomainError) {
Line 92: return Guid.Empty;
we previously had three states:
1. return guid of task to do the polling on
2. get runtime exception
3. get succeeded=false, and return null so that the caller will return false
I needed a way to distinguish a new state where we get image-does-not-exist
error - in this case the operation basically succeeded so the caller should not
return false, but there is no task to monitor. so I used the empty guid to mark
this state.
Line 93: }
Line 94: throw e;
Line 95: }
Line 96:
--
To view, visit http://gerrit.ovirt.org/17056
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5dce38bed0675306d647b3830fe2d208e19d0d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
