Omer Frenkel has posted comments on this change. Change subject: core: ignore image does not exists error on remove memory state ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/memory/MemoryImageRemover.java Line 88: } Line 89: } Line 90: catch(VdcBLLException e) { Line 91: if (e.getErrorCode() == VdcBllErrors.ImageDoesNotExistInDomainError) { Line 92: return Guid.Empty; why empty guid and not null Line 93: } Line 94: throw e; Line 95: } Line 96: -- To view, visit http://gerrit.ovirt.org/17056 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5dce38bed0675306d647b3830fe2d208e19d0d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches