Sandro Bonazzola has posted comments on this change.
Change subject: packaging: setup: firewall configuration
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File src/plugins/ovirt-hosted-engine-setup/network/firewall_manager.py
Line 149: if response == _('yes'):
Line 150: self.environment[
Line 151: ohostedcons.NetworkEnv.FIREWALL_MANAGER
Line 152: ] = manager
Line 153: break
I've done the same thing we're doing in engine-setup-2 for being coherent with
the UX used there. Remember that most system have just one firewall manager
installed so there will be just one question instead of a list of [manager,
none].
Line 154:
Line 155: self.environment[otopicons.NetEnv.IPTABLES_ENABLE] = (
Line 156: self.environment[
Line 157: ohostedcons.NetworkEnv.FIREWALL_MANAGER
Line 151: ohostedcons.NetworkEnv.FIREWALL_MANAGER
Line 152: ] = manager
Line 153: break
Line 154:
Line 155: self.environment[otopicons.NetEnv.IPTABLES_ENABLE] = (
We've to tell to otopi to enable the iptables plugin.
Line 156: self.environment[
Line 157: ohostedcons.NetworkEnv.FIREWALL_MANAGER
Line 158: ] == 'iptables'
Line 159: )
Line 157: ohostedcons.NetworkEnv.FIREWALL_MANAGER
Line 158: ] == 'iptables'
Line 159: )
Line 160: self.environment[otopicons.NetEnv.FIREWALLD_ENABLE] = (
Line 161: self.environment[
We've to tell to otopi to enable the firewalld plugin.
Line 162: ohostedcons.NetworkEnv.FIREWALL_MANAGER
Line 163: ] == 'firewalld'
Line 164: )
Line 165:
....................................................
File templates/hosted-console.xml.in
Line 2: <service>
Line 3: <short>hosted-console</short>
Line 4: <description>oVirt Hosted Engine console service</description>
Line 5: <port protocol="tcp" port="5900"/>
Line 6: <port protocol="udp" port="5900"/>
If other ports are needed they will be opened by ovirt-host-deploy when the
engine adds the host, no?
--
To view, visit http://gerrit.ovirt.org/16877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c3ac2ae97416f4a9b82f9a7c404350345a0c765
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
