Alex Lourie has posted comments on this change.
Change subject: packaging: setup: firewall configuration
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File src/plugins/ovirt-hosted-engine-setup/network/firewall_manager.py
Line 149: if response == _('yes'):
Line 150: self.environment[
Line 151: ohostedcons.NetworkEnv.FIREWALL_MANAGER
Line 152: ] = manager
Line 153: break
Agree with Didi, we could just show all the list in VALUES, no?
Line 154:
Line 155: self.environment[otopicons.NetEnv.IPTABLES_ENABLE] = (
Line 156: self.environment[
Line 157: ohostedcons.NetworkEnv.FIREWALL_MANAGER
--
To view, visit http://gerrit.ovirt.org/16877
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c3ac2ae97416f4a9b82f9a7c404350345a0c765
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Lev Veyde <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
