Omer Frenkel has posted comments on this change.
Change subject: core, restapi, webadmin, userportal: cloud-init [3/6] - backend
......................................................................
Patch Set 6: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
Line 61: getVm().setRunOnce(true);
Line 62: CreateVmVDSCommandParameters createVmParams =
super.initCreateVmParams();
Line 63: RunVmOnceParams runOnceParams = getParameters();
Line 64:
Line 65: SysPrepParams sysPrepParams = new SysPrepParams();
Done
Line 66:
sysPrepParams.setSysPrepDomainName(runOnceParams.getSysPrepDomainName());
Line 67:
sysPrepParams.setSysPrepUserName(runOnceParams.getSysPrepUserName());
Line 68:
sysPrepParams.setSysPrepPassword(runOnceParams.getSysPrepPassword());
Line 69: createVmParams.setSysPrepParams(sysPrepParams);
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java
Line 20: private String privateFloppyPath;
Line 21: private String privateClientIp;
Line 22: private VdcUser privateRequestingUser;
Line 23: private Guid _destinationVdsId;
Line 24: private InitializationType privateInitializationType;
Done
Line 25: private Boolean privateRunAsStateless;
Line 26: private String initrd_url;
Line 27: private String kernel_url;
Line 28: private String kernel_params;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java
Line 971: setGuestLastLogoutTime(new Date());
Line 972: }
Line 973: }
Line 974:
Line 975: private InitializationType initializationType;
Done
Line 976:
Line 977: public InitializationType getInitializationType() {
Line 978: return initializationType;
Line 979: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java
Line 136: private void run()
Line 137: {
Line 138: VM entity = (VM) getItem().getEntity();
Line 139: // use sysprep iff the vm is not initialized and vm has Win OS
Line 140: boolean reinitialize = !entity.isInitialized() &&
AsyncDataProvider.isWindowsOsType(entity.getVmOsId());
Done
Line 141: RunVmParams tempVar = new RunVmParams(entity.getId());
Line 142: tempVar.setInitializationType(InitializationType.Sysprep);
Line 143: Frontend.RunAction(VdcActionType.RunVm, tempVar);
Line 144: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
Line 855: // and [Reinitialize-sysprep == true || IsVmFirstRun == true
(IsVmFirstRun == !VM.is_initialized) and no attached
Line 856: // floppy]
Line 857: private void updateIsSysprepEnabled()
Line 858: {
Line 859: boolean isFloppyAttached = (Boolean)
getAttachFloppy().getEntity();
not sure, but these are removed in change number 5 and there it looks ok
Line 860: boolean isVmFirstRun = (Boolean)
getIsVmFirstRun().getEntity();
Line 861:
Line 862: getIsSysprepEnabled().setEntity(getIsWindowsOS() &&
getInitializationType() == InitializationType.Sysprep);
Line 863: }
--
To view, visit http://gerrit.ovirt.org/14350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida8ffa5b92ff79cdac5e401c0a815ffcf517590d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
