Ori Liel has posted comments on this change.
Change subject: core, restapi, webadmin, userportal: cloud-init [3/6] - backend
......................................................................
Patch Set 10: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
Line 254: params.setInitializationType(InitializationType.Sysprep);
Line 255: } else if
(SimpleDependecyInjector.getInstance().get(OsRepository.class).isLinux(vm.getVmOsId())
&& params.getCloudInitParameters() != null) {
Line 256:
params.setInitializationType(InitializationType.CloudInit);
Line 257: } else {
Line 258: params.setInitializationType(InitializationType.None);
We should take this opportunity to move all of this logic to the backend.
Line 259: }
Line 260: return params;
Line 261: }
Line 262:
--
To view, visit http://gerrit.ovirt.org/14350
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida8ffa5b92ff79cdac5e401c0a815ffcf517590d
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
