Laszlo Hornyak has posted comments on this change.

Change subject: webadmin: Cluster Policy Dialog
......................................................................


Patch Set 10: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java
Line 39: public class RoleListModel extends ListWithDetailsModel
Line 40: {
Line 41:     public static final String COPY_OF = "Copy_of_"; //$NON-NLS-1$
Line 42: 
Line 43:     public enum CommandType
Looks like it is still not used anywhere outside this class, is this change 
needed?
Line 44:     {
Line 45:         New,
Line 46:         Edit,
Line 47:         Clone;


-- 
To view, visit http://gerrit.ovirt.org/16113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e44684c9305cbe9f0f6c632331f86007ef67747
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to