Laszlo Hornyak has posted comments on this change.
Change subject: webadmin: Cluster Policy Dialog
......................................................................
Patch Set 10: Verified; Looks good to me, but someone else must approve
(3 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
Line 532: obj.setDescription(clusterPolicy.getDescription());
Line 533: obj.setLocked(clusterPolicy.isLocked());
Line 534: obj.setDefaultPolicy(clusterPolicy.isDefaultPolicy());
Line 535: if (clusterPolicy.getFilters() != null) {
Line 536: obj.setFilters(new ArrayList<Guid>());
Isn't it more simple to new ArrayList<Guid>(clusterPolicy.getFilters()) ?
Line 537: for (Guid policyUnitId : clusterPolicy.getFilters()) {
Line 538: obj.getFilters().add(policyUnitId);
Line 539: }
Line 540: }
Line 538: obj.getFilters().add(policyUnitId);
Line 539: }
Line 540: }
Line 541: if (clusterPolicy.getFilterPositionMap() != null) {
Line 542: obj.setFilterPositionMap(new HashMap<Guid, Integer>());
-||-
Line 543: for (Entry<Guid, Integer> entry :
clusterPolicy.getFilterPositionMap().entrySet()) {
Line 544: obj.getFilterPositionMap().put(entry.getKey(), new
Integer(entry.getValue()));
Line 545: }
Line 546: }
Line 544: obj.getFilterPositionMap().put(entry.getKey(), new
Integer(entry.getValue()));
Line 545: }
Line 546: }
Line 547: if (clusterPolicy.getFunctions() != null) {
Line 548: obj.setFunctions(new ArrayList<Pair<Guid, Integer>>());
-||-
Line 549: for (Pair<Guid, Integer> pair :
clusterPolicy.getFunctions()) {
Line 550: obj.getFunctions().add(new Pair<Guid,
Integer>(pair.getFirst(), pair.getSecond()));
Line 551: }
Line 552: }
--
To view, visit http://gerrit.ovirt.org/16113
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e44684c9305cbe9f0f6c632331f86007ef67747
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
