Michal Skrivanek has posted comments on this change. Change subject: agent: Build and install ovirt guest agent on Ubuntu ......................................................................
Patch Set 7: (6 inline comments) .................................................... File debian/copyright Line 6: Copyright: 2009-2013 Red Hat, Inc. and/or its affiliates Line 7: License: Apache Line 8: Licensed under the Apache License, Version 2.0 (the "License"); Line 9: you may not use this file except in compliance with the License. Line 10: You may obtain a copy of the License at whitespace followed by \n? Line 11: http://www.apache.org/licenses/LICENSE-2.0 Line 12: Unless required by applicable law or agreed to in writing, software Line 13: distributed under the License is distributed on an "AS IS" BASIS, Line 14: WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. .................................................... File debian/ovirt-guest-agent.upstart Line 1: # ovirt-guest-agent - oVirt guest agent Line 2: # Line 3: Line 4: description "oVirt guest agent" tab? Line 5: Line 6: start on runlevel [2345] Line 7: stop on runlevel [!2345] Line 8: Line 18: Line 19: pre-start script Line 20: touch /var/run/ovirt-guest-agent.pid Line 21: chown ovirtagent:ovirtagent /var/run/ovirt-guest-agent.pid Line 22: chown ovirtagent:ovirtagent -R /var/log/ovirt-guest-agent why -R? Line 23: end script Line 24: Line 25: exec sudo -u ovirtagent -g ovirtagent python /usr/share/ovirt-guest-agent/ovirt-guest-agent.py Line 26: .................................................... File debian/postinst Line 1: #!/bin/bash Line 2: set -e Line 3: Line 4: udevadm control --reload-rules whitespace Line 5: udevadm trigger --subsystem-match="virtio-ports" --attr-match="name=com.redhat.rhevm.vdsm" Line 6: udevadm settle Line 7: .................................................... File ovirt-guest-agent/hibernate Line 6: } Line 7: Line 8: state="$1" Line 9: Line 10: if [ $state = "disk" ]; then "$state" will make it work nice on debian as well:) Line 11: param="hibernate" Line 12: elif [ $state = "mem" ]; then Line 13: param="suspend" Line 14: else .................................................... File ovirt-guest-agent/Makefile.am Line 1: Line 2: SUBDIRS = pam consoleapps still - \r Line 3: Line 4: AGENT_NAME = ovirt-guest-agent Line 5: Line 6: agentdir=$(datadir)/ovirt-guest-agent -- To view, visit http://gerrit.ovirt.org/15313 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a694bf1f7ff4230bac305dd571899265ef63950 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
