Vinzenz Feenstra has posted comments on this change.

Change subject: agent: Build and install ovirt guest agent on Ubuntu
......................................................................


Patch Set 3: (5 inline comments)

....................................................
File Makefile.am
Line 27:     AUTHORS                     \
Line 28:     README_Fedora.txt           \
Line 29:     ovirt-guest-agent.spec      \
Line 30:        m4/fhs.m4                                       \
Line 31:        debian                                          \
Done
Line 32:     $(NULL)
Line 33: 
Line 34: # When fixing a file to conform with pep8 add it to the WL here so it 
will be
Line 35: # checkd from now on


....................................................
File ovirt-guest-agent/hibernate
Line 1: #!/bin/bash
Done
Line 2: 
Line 3: usage() {
Line 4:     echo "usage: $0 disk|mem"
Line 5:     exit 1


Line 6: }
Line 7: 
Line 8: state="$1"
Line 9: 
Line 10: if [ $state == "disk" ]; then
Done
Line 11:     param="hibernate"
Line 12: elif [ $state == "mem" ]; then
Line 13:     param="suspend"
Line 14: else


Line 7: 
Line 8: state="$1"
Line 9: 
Line 10: if [ $state == "disk" ]; then
Line 11:     param="hibernate"
Done
Line 12: elif [ $state == "mem" ]; then
Line 13:     param="suspend"
Line 14: else
Line 15:     usage


....................................................
File ovirt-guest-agent/ovirt-guest-agent.in
Line 1: #!/bin/bash
Done
Line 2: #
Line 3: # ovirt-guest-agent - Startup script for the oVirt agent daemon
Line 4: #
Line 5: # chkconfig: 35 85 15


-- 
To view, visit http://gerrit.ovirt.org/15313
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a694bf1f7ff4230bac305dd571899265ef63950
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to