Allon Mureinik has posted comments on this change.
Change subject: core: restapi: Introducing ImportVmFromConfigurationCommand
......................................................................
Patch Set 7: (3 inline comments)
@aburden - I'd like your input on the properties files, 10x
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImportVmFromConfigurationParameters.java
Line 9: @NotNull
Line 10: private String vmConfiguration;
Line 11: @NotNull
Line 12: private ConfigurationType configurationType;
Line 13:
probably also needs an empty ctor and serialVersionUUID for serialization.
Line 14: public ImportVmFromConfigurationParameters(ConfigurationType
configurationType, String vmConfiguration, Guid vdsGroupId) {
Line 15: super();
Line 16: this.configurationType = configurationType;
Line 17: this.vmConfiguration = vmConfiguration;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ConfigurationType.java
Line 1: package org.ovirt.engine.core.common.businessentities;
Line 2:
Line 3: public enum ConfigurationType {
we need a better name for this - perhaps ImportVmFormat ?
Line 4: OVF;
....................................................
Commit Message
Line 3: AuthorDate: 2013-07-04 16:50:55 +0300
Line 4: Commit: Liron Aravot <lara...@redhat.com>
Line 5: CommitDate: 2013-07-07 16:36:04 +0300
Line 6:
Line 7: core: restapi: Introducing ImportVmFromConfigurationCommand
s/core: restapi:/core,restapi:/
Line 8:
Line 9: ImportVmFromConfigurationCommand is used for adding a vm to the engine
Line 10: with a configuration specified in an ovf file.
Line 11: The command adds the vm and related devices as specified in the given
--
To view, visit http://gerrit.ovirt.org/15894
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9390bcc11e5f3cb8c8c89ce791aabe63fe0ca341
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: A Burden <abur...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
