A Burden has posted comments on this change.

Change subject: core: restapi: Introducing ImportVmFromConfigurationCommand
......................................................................


Patch Set 7: (1 inline comment)

Allon, I could only find 6 changes in the properties files - at least that's 
what I presume the 10x meant :)
The only suggested change I made was in:
AuditLogMessages.properties
Cheers

....................................................
File 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 301: VM_PAUSED_EIO=VM ${VmName} has paused due to storage I/O problem.
Line 302: VM_PAUSED_EPERM=VM ${VmName} has paused due to storage permissions 
problem.
Line 303: VM_POWER_DOWN_FAILED=Shutdown of VM ${VmName} failed.
Line 304: VM_IMPORT_FROM_CONFIGURATION_EXECUTED_SUCCESFULLY=VM ${VmName} has 
been successfully imported from the given configuration.
Line 305: VM_IMPORT_FROM_CONFIGURATION_ATTACH_DISKS_FAILED=VM ${VmName} has 
been imported from the given configuration, failed to attach to it following 
disk(s): ${DiskAliases}.
Suggestion:
"VM ${VmName} has been imported from the given configuration but failed to be 
attached to the following disk(s): ${DiskAliases}."
Line 306: VDS_INSTALL=Host ${VdsName} installed
Line 307: VDS_INSTALL_FAILED=Host ${VdsName} installation failed. 
${FailedInstallMessage}.
Line 308: VDS_INITIALIZING=Host ${VdsName} is initializing. Message: 
${ErrorMessage}
Line 309: VDS_INITIATED_RUN_VM=VM ${VmName} was restarted on Host ${VdsName}


-- 
To view, visit http://gerrit.ovirt.org/15894
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9390bcc11e5f3cb8c8c89ce791aabe63fe0ca341
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: A Burden <abur...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to