Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: changed PGPASSFILE usage in db validations ......................................................................
Patch Set 6: (2 inline comments) totally minor comments .................................................... File backend/manager/tools/dbutils/common.sh Line 18 Line 19 Line 20 Line 21 Line 22 please remove .................................................... Commit Message Line 10: value. This overrides the value provided by the setup and in Line 11: some cases causes incorrect password to be supplied to the DB Line 12: utilities. Line 13: Line 14: The new approach updates the value of PGPASSFILE to the extra space to..the Line 15: ENGINE_PGPASS provided by the setup. Line 16: Line 17: Change-Id: Ib20a80aff04ac5f977b55ee9a5e71607292ea8ff -- To view, visit http://gerrit.ovirt.org/16469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib20a80aff04ac5f977b55ee9a5e71607292ea8ff Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
