Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Removed unnecessary DB defaults ......................................................................
Patch Set 4: (1 inline comment) .................................................... File backend/manager/tools/dbutils/common.sh Line 16 Line 17 Line 18 Line 19 Line 20 so we have two set_defaults, one in common.sh and one in dbcustomfunction.sh both are invalid, as they fallback the ENGINE_PGPASS, but at least we can synchronize the two. -- To view, visit http://gerrit.ovirt.org/16469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib20a80aff04ac5f977b55ee9a5e71607292ea8ff Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches