Omer Frenkel has posted comments on this change.
Change subject: engine:Trusted Compute Pools - Open Attestation integration
with oVirt engine proposal
......................................................................
Patch Set 24: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 274:
Line 275: private void setNonOperational(NonOperationalReason reason, VDS
vds) {
Line 276: vds.setNonOperationalReason(reason);
Line 277: vds.setStatus(VDSStatus.NonOperational);
Line 278:
DbFacade.getInstance().getVdsDynamicDao().update(vds.getDynamicData());
not sure which is worse.. user doesnt know why the host is non operational, or
the log is flooded, lets leave it and wait for feedback (if any)
Line 279: }
Line 280:
Line 281: private void initSearchDependencies() {
Line 282: SimpleDependecyInjector.getInstance().bind(new
OsValueAutoCompleter(OsRepositoryImpl.INSTANCE.getUniqueOsNames()));
--
To view, visit http://gerrit.ovirt.org/14605
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ce3448a821c74521d277f92f2c8d63ba0accfed
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gang Wei <gang....@intel.com>
Gerrit-Reviewer: Dave Chen <wei.d.c...@intel.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Emily Zhang <lijuan.zh...@intel.com>
Gerrit-Reviewer: Gang Wei <gang....@intel.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
