ofri masad has posted comments on this change. Change subject: engine:Trusted Compute Pools - Open Attestation integration with oVirt engine proposal ......................................................................
Patch Set 24: (2 inline comments) Agree. in current implementation no special treatment is needed in 'confirm host has been rebooted' .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java Line 274: Line 275: private void setNonOperational(NonOperationalReason reason, VDS vds) { Line 276: vds.setNonOperationalReason(reason); Line 277: vds.setStatus(VDSStatus.NonOperational); Line 278: DbFacade.getInstance().getVdsDynamicDao().update(vds.getDynamicData()); this will create an audit log for each host which is in trusted cluster. every time you will start the engine you will get hundreds of error log messages . Line 279: } Line 280: Line 281: private void initSearchDependencies() { Line 282: SimpleDependecyInjector.getInstance().bind(new OsValueAutoCompleter(OsRepositoryImpl.INSTANCE.getUniqueOsNames())); .................................................... File packaging/dbscripts/create_views.sql Line 628: Line 629: CREATE OR REPLACE VIEW vds Line 630: as Line 631: SELECT vds_groups.vds_group_id as vds_group_id, vds_groups.name as vds_group_name, vds_groups.description as vds_group_description, Line 632: vds_groups.selection_algorithm as selection_algorithm, vds_groups.trusted_service as trusted_service,vds_static.vds_id as vds_id, vds_static.vds_name as vds_name, vds_static.ip as ip, vds_static.vds_unique_id as vds_unique_id, will remove Line 633: vds_static.host_name as host_name, vds_static.port as port, vds_static.vds_strength as vds_strength, vds_static.server_SSL_enabled as server_SSL_enabled, vds_static.vds_type as vds_type, Line 634: vds_static.pm_type as pm_type, vds_static.pm_user as pm_user, vds_static.pm_password as pm_password, vds_static.pm_port as pm_port, Line 635: vds_static.pm_options as pm_options, vds_static.pm_enabled as pm_enabled, Line 636: vds_static.pm_proxy_preferences as pm_proxy_preferences,vds_static.pm_secondary_ip as pm_secondary_ip, -- To view, visit http://gerrit.ovirt.org/14605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ce3448a821c74521d277f92f2c8d63ba0accfed Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gang Wei <gang....@intel.com> Gerrit-Reviewer: Dave Chen <wei.d.c...@intel.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Emily Zhang <lijuan.zh...@intel.com> Gerrit-Reviewer: Gang Wei <gang....@intel.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-Reviewer: ofri masad <oma...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches