Spenser Shumaker has uploaded a new change for review. Change subject: <core | engine>: AuditLogDirector.log(*) methods now update engine.log ......................................................................
<core | engine>: AuditLogDirector.log(*) methods now update engine.log Every event that appears in the admin console's event viewer is now logged permanently to the log file for posterity. Change-Id: I006229291b9a265d7fc6e1d822d2c64b2839aaff Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=966192 Signed-off-by: Spenser Shumaker <sshum...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 2 files changed, 32 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/16188/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java index d25940f..a98f5d6 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java @@ -477,4 +477,33 @@ public void setCallStack(String callStack) { this.callStack = callStack; } -} + + public String toStringForLogging() { + StringBuilder sb = new StringBuilder(); + if(correlationId != null){ + sb.append("Corrolation ID: "); + sb.append(correlationId); + sb.append(", "); + } + if(jobId != null){ + sb.append("Job ID: "); + sb.append(jobId.toString()); + sb.append(", "); + } + if(callStack != null){ + sb.append("Call Stack: "); + sb.append(callStack); + sb.append(", "); + } + if(customEventId != -1){ + sb.append("Custom Event ID: "); + sb.append(customEventId); + sb.append(", "); + } + if(message != null){ + sb.append("Message: "); + sb.append(message); + } + return sb.toString(); + } +} \ No newline at end of file diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java index c6a5ffa..b1a3fad 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java @@ -907,6 +907,8 @@ getDbFacadeInstance().getAuditLogDao().save(auditLog); if (!"".equals(loggerString)) { log.infoFormat(loggerString, resolvedMessage); + } else { + log.info(auditLog.toStringForLogging()); } } } -- To view, visit http://gerrit.ovirt.org/16188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I006229291b9a265d7fc6e1d822d2c64b2839aaff Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Spenser Shumaker <sshum...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
