Yair Zaslavsky has posted comments on this change.
Change subject: Adding to VdsStatic ssh_username and ssh_port
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
Line 74: entity.setPort(model.getPort());
Line 75: } else {
Line 76: entity.setPort(DEFAULT_VDSM_PORT);
Line 77: }
Line 78: if (model.isSetSshPort() && model.getSshPort() > 0) {
See my other comment about Host.
Did you discuss with Michael Pasternak about whether we will present (or not )
these fields in Host entity of API?
Line 79: entity.setSSHPort(model.getSshPort());
Line 80: } else {
Line 81: entity.setSSHPort(DEFAULT_SSH_PORT);
Line 82: }
....................................................
File
backend/manager/modules/root/src/main/java/org/ovirt/engine/core/register/RegisterServlet.java
Line 57: String strIP = "";
Line 58: String strName = "";
Line 59: String strID = "";
Line 60: int nPort = -1;
Line 61: int nSshPort = 22;
once again, no need to copy paste ugly/wrong naming convention.
should be sshPort.
Line 62: String strSshUsername = "root";
Line 63: String otpMessage = "";
Line 64:
Line 65: try {
--
To view, visit http://gerrit.ovirt.org/16096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2c38d23faadc4dbed65d08298e0862c5bea26dd
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
