Yair Zaslavsky has posted comments on this change.
Change subject: Adding to VdsStatic ssh_username and ssh_port
......................................................................
Patch Set 6: (2 inline comments)
Please move api.xsd to separate patch that deals with api.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
Line 104: && ObjectUtils.objectsEqual(vdsGroupGlusterService,
other.vdsGroupGlusterService));
Line 105: }
Line 106:
Line 107: public VDS(Guid vds_group_id, String vds_group_name, String
vds_group_description, Guid vds_id, String vds_name,
Line 108: String ip, String host_name, int port, int ssh_port,
String ssh_username, int status, Integer cpu_cores, Integer cpuThreads, String
cpu_model,
The fact there ugly parmaeter names does not mean we need to continue having
them in new params.
I would highly appreciate if you change ssh_port and ssh_username ot sshPort
and sshUserName
Line 109: String hwManufacturer, String hwProductName,
Line 110: String hwVersion, String hwSerialNumber, String hwUUID,
String hwFamily,
Line 111: Double cpu_speed_mh, String if_total_speed, Boolean
kvm_enabled, Integer physical_mem_mb,
Line 112: Double cpu_idle, Double cpu_load, Double cpu_sys,
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/RegisterVdsParameters.java
Line 79: private void setSSHPort(int value) {
Line 80: privateSSHPort = value;
Line 81: }
Line 82:
Line 83: private String privateSSHUsername;
remove the "private" prefix.
No need.
Line 84:
Line 85: public String getSSHUsername() {
Line 86: return privateSSHUsername;
Line 87: }
--
To view, visit http://gerrit.ovirt.org/16096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2c38d23faadc4dbed65d08298e0862c5bea26dd
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
