Omer Frenkel has posted comments on this change. Change subject: core: use instance type in addVm + permissions ......................................................................
Patch Set 18: (1 inline comment) .................................................... Commit Message Line 5: CommitDate: 2013-06-25 09:53:01 +0300 Line 6: Line 7: core: use instance type in addVm + permissions Line 8: Line 9: Added new ActionGroup CREATE_INSTANCE that allow user to create only instance is the name used in other cloud providers for a vm, this is the name used in the code and should be in the various front-ends as well. it is also documented in the wiki: http://www.ovirt.org/Features/Instance_Types since this is the named already used, and not "our invention" i think its better to use the same name so users from ec2 for example will be familiar with the names when using ovirt Line 10: instance, which is more 'weak' than create vm because of the smaller set Line 11: of parameters the user can set to an instance compared to vm. Line 12: Line 13: Added new roles to be used: InstanceCreator and UserInstanceManager -- To view, visit http://gerrit.ovirt.org/12281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9058907d1021b09981671e905defb91ed645d65 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches