Michael Pasternak has posted comments on this change. Change subject: core: use instance type in addVm + permissions ......................................................................
Patch Set 18: Looks good to me, but someone else must approve (1 inline comment) tiny comment on the AG name. .................................................... Commit Message Line 5: CommitDate: 2013-06-25 09:53:01 +0300 Line 6: Line 7: core: use instance type in addVm + permissions Line 8: Line 9: Added new ActionGroup CREATE_INSTANCE that allow user to create only if i was a user and looking on CREATE_INSTANCE, i'd never figure out what it means and how it's different from the CREATE_X (where X is a object in the system, after all any object is a instance as well ...), maybe you should consider calling it CREATE_EXPOSIT, CREATE_ILLUSTRATION, CREATE_SKETCH or similar?! Line 10: instance, which is more 'weak' than create vm because of the smaller set Line 11: of parameters the user can set to an instance compared to vm. Line 12: Line 13: Added new roles to be used: InstanceCreator and UserInstanceManager -- To view, visit http://gerrit.ovirt.org/12281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9058907d1021b09981671e905defb91ed645d65 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
