Alon Bar-Lev has posted comments on this change.
Change subject: Adding query for fetching ssh pubic key
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 181: /**
Line 182: * Return the engine ssh public key to install on host.
Line 183: * @return ssh public key.
Line 184: */
Line 185: public static String _getEngineSSHPublicKey() {
If you turn this public, the you should also remove the _
But I really don't like mesh programming... if this is required by two logic
classes it should be static at utility class.
Line 186: final EngineLocalConfig config =
EngineLocalConfig.getInstance();
Line 187: final String keystoreFile =
config.getPKIEngineStore().getAbsolutePath();
Line 188: final char[] password =
config.getPKIEngineStorePassword().toCharArray();
Line 189: final String alias = config.getPKIEngineStoreAlias();
--
To view, visit http://gerrit.ovirt.org/16019
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie508d6f9bdaa482f46a3cf1224b2fd84568299ba
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
