Alon Bar-Lev has posted comments on this change.

Change subject: Adding query for fetching ssh pubic key
......................................................................


Patch Set 3:

> Thats the way to pass the publickey string to the frontend and show it in the 
> textarea. as we do with the fingerprint.

Oh... it is the *ENGINE* public key that need to be there, not the host. And 
you need it at OpenSSH format.

Please copy the code from VdsDeploy::_getEngineSSHPublicKey()

We probably need some util to have this in common.

> I don't need to rebase it above anything, its a new query. I need to rebase 
> the UI part over that to allow querying the publicKey.

But the new query should use the new object = rebase.

-- 
To view, visit http://gerrit.ovirt.org/16019
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie508d6f9bdaa482f46a3cf1224b2fd84568299ba
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to