Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: Log setup/cleanup/upgrade actions
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File packaging/bin/ovirt-engine-log-setup-event.sh.in
Line 52: esac
Line 53: done
Line 54:
Line 55: get_distro_name() {
Line 56: python -c 'import platform; print
platform.linux_distribution(full_distribution_name=0)[0]'
I've done one time this mistake when I first installed gentoo and needed
acrobat... and did not know the alternatives. no I don't have rpm.
but had I rpm, then I should have listed portage and rpm packages to get the
complete picture...
should be the easiest and most generic the derive the tool from distribution.
but I think we wasted too much time on this script.
Line 57: }
Line 58:
Line 59: get_distro_packages() {
Line 60: distro=$(get_distro_name)
--
To view, visit http://gerrit.ovirt.org/15863
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae455ff0ef6475f00243906738474134f6f4e6e3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
